Unset metadata prefetch memory limits. #516
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hime
commented
Jun 30, 2025
| @@ -53,6 +53,7 @@ | |||
| "gke-gcsfuse/cpu-limit": "0", | |||
| "gke-gcsfuse/memory-limit": "0", | |||
| "gke-gcsfuse/ephemeral-storage-limit": "0", | |||
| "gke-gcsfuse/metadata-prefetch-memory-limit": "0", | |||
There was a problem hiding this comment.
This is only required when argument "prefetch_metadata" is provided, what would be the best place to add this check?
There was a problem hiding this comment.
You would have to add the prefetch_metadata flag to Storage CRD and change this const to a function that would take the list of storages and check if any of them has the flag set.
I'm not against adding it as default here, as it probably doesn't do anything if gcsfuseMetadataPrefetchOnMount is not set (correct me if I'm wrong).
In either case I would also consider removing gke-gcsfuse/metadata-prefetch-cpu-limit and gke-gcsfuse/metadata-prefetch-ephemeral-storage-limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Testing for this repo is pending.
Testing details.